Re: [xfs] c91c46c12: xfstests generic/313 regression

xfs

Re: [xfs] c91c46c12: xfstests generic/313 regression

To:	xfs@xxxxxxxxxxx
Subject:	Re: [xfs] c91c46c12: xfstests generic/313 regression
From:	Brian Foster <bfoster@xxxxxxxxxx>
Date:	Wed, 29 Jan 2014 08:13:37 -0500
Cc:	hch@xxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20140111111045.GA29380@xxxxxxxxxxxxx>
References:	<20140110122700.GA12624@localhost> <52CFF402.5080409@xxxxxxxxxx> <20140110133306.GA22918@xxxxxxxxxxxxx> <52CFFD1C.7050005@xxxxxxxxxx> <20140111111045.GA29380@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

On 01/11/2014 06:10 AM, Christoph Hellwig wrote:
> On Fri, Jan 10, 2014 at 10:01:00PM +0800, Jeff Liu wrote:
>> I also thought to fix this problem in this way, however I'm not sure
>> if those flags can be set back to iattr->ia_valid internally...
>>
>> Otherwise, this fix looks good to me.
> 
> Nothing in the truncate or open code path (or non-size setattr for that
> matter) looks at ia_valid after calling the filesystem, and they really
> have no business to.
> 
> In the meantime this has passed xfstests, so I'll send it along.  Thanks
> for the first fix, btw!
> 

ping... any plans to repost this with a proper commit log and whatnot?
Thanks.

Brian

> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[xfs] c91c46c12: xfstests generic/313 regression, fengguang . wu Re: [xfs] c91c46c12: xfstests generic/313 regression, Jeff Liu Re: [xfs] c91c46c12: xfstests generic/313 regression, Christoph Hellwig Re: [xfs] c91c46c12: xfstests generic/313 regression, Jeff Liu Re: [xfs] c91c46c12: xfstests generic/313 regression, Christoph Hellwig Re: [xfs] c91c46c12: xfstests generic/313 regression, Brian Foster <= Re: [xfs] c91c46c12: xfstests generic/313 regression, Christoph Hellwig [PATCH] xfs: ensure correct timestamp updates from truncate, Christoph Hellwig Re: [PATCH] xfs: ensure correct timestamp updates from truncate, Jeff Liu Re: [PATCH] xfs: ensure correct timestamp updates from truncate, Brian Foster Re: [PATCH] xfs: ensure correct timestamp updates from truncate, Ben Myers

Previous by Date:	Re: [PATCH] xfstests: don't use TEST_DIR before initialized in generic/313, Jeff Liu
Next by Date:	Not being able to recover a RAID 5 20 Tb partition, help needed, Juan A. Sillero
Previous by Thread:	Re: [xfs] c91c46c12: xfstests generic/313 regression, Christoph Hellwig
Next by Thread:	Re: [xfs] c91c46c12: xfstests generic/313 regression, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]