xfs
[Top] [All Lists]

Re: [PATCH] xfstests: remove spurious line continuation from _require_xf

To: Brian Foster <bfoster@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfstests: remove spurious line continuation from _require_xfs_crc
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Wed, 29 Jan 2014 19:55:27 +0800
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1390932092-44727-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1390932092-44727-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 01/29 2014æ 02:01 AM, Brian Foster wrote:
> This causes the mkfs to fail and leads to tests being skipped.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
> ---
>  common/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/rc b/common/rc
> index 49c86de..e91568b 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1180,7 +1180,7 @@ _require_xfs_mkfs_crc()
>  #
>  _require_xfs_crc()
>  {
> -     _scratch_mkfs_xfs -m crc=1 >/dev/null 2>&1 \
> +     _scratch_mkfs_xfs -m crc=1 >/dev/null 2>&1
>       _scratch_mount >/dev/null 2>&1 \
>          || _notrun "Kernel doesn't support crc feature"
>       umount $SCRATCH_MNT
> 

Looks good to me.

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>

Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>