xfs
[Top] [All Lists]

Re: [PATCH] xfstests: make test btrfs/025 more robust

To: Filipe David Borba Manana <fdmanana@xxxxxxxxx>, <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: make test btrfs/025 more robust
From: Josef Bacik <jbacik@xxxxxx>
Date: Tue, 28 Jan 2014 09:51:47 -0500
Cc: <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=message-id : date : from : mime-version : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=tj+XyQUaJKylQslpo1t9nZYdhDfJDgt+0OA4kxMAprk=; b=qgGeBFvaKLmDhAYbwqydgcRVL3FPfPOWejFpTPgAe92qVKcKxaWXFKPHJyxS9Zat9k0B YtFWCCTI5WzY4DLsLwpmVEKJi1tUQqKJHeMpwQt+wqrWQxf9eblfy1yOy2BKbYGyblcF R8ORWGIg5hYUslF8jXLwuL+5le2SDV2yHLk=
In-reply-to: <1390920396-20311-1-git-send-email-fdmanana@xxxxxxxxx>
References: <1390920396-20311-1-git-send-email-fdmanana@xxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 01/28/2014 09:46 AM, Filipe David Borba Manana wrote:
Make the test btrfs/025 not depend on the output of the btrfs tools
subvolume, send, receive and filesystem commands output. The output
of these commands has changed several times in the past, and it can
change again in the future. Therefore just test for failure/success
and not for the exact output on the success case.

Signed-off-by: Filipe David Borba Manana <fdmanana@xxxxxxxxx>

Wow sorry didn't realize this already got taken, but still a good change to have anyway.

Reviewed-by: Josef Bacik <jbacik@xxxxxx>

Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>