xfs
[Top] [All Lists]

Re: [PATCH] xfstests: add test for btrfs incremental send data corruptio

To: Filipe David Borba Manana <fdmanana@xxxxxxxxx>, <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: add test for btrfs incremental send data corruption
From: Josef Bacik <jbacik@xxxxxx>
Date: Tue, 28 Jan 2014 08:56:23 -0500
Cc: <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=message-id : date : from : mime-version : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=wTTWVnywIvMgPCEVYEKb1U4UaPpdAD68/wxA4jVw27w=; b=HmOX0/H6uhoLKv7LMNQvZA38TuHnfYyrl5cjnI1kkhCq1XaJ7BnjEs0tf5zGaAUaQ2ge UL5UURiu+y4w276/BtQf1Ao99DFihA13CAwCUk5Bmml4bGeLcYNCPG6e2QC+lwy9eUh5 0KERCbG3YKGS7TI2nXoL6oO3DF43f7rxVCM=
In-reply-to: <1390873242-8723-1-git-send-email-fdmanana@xxxxxxxxx>
References: <1390873242-8723-1-git-send-email-fdmanana@xxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 01/27/2014 08:40 PM, Filipe David Borba Manana wrote:
Btrfs incremental send had an issue where it would detect a non-existent
file hole and then overwrite the file section that hole covers with zeroes,
overriding file data that it shouldn't.

The respective btrfs kernel patch that fixed this issue is titled:

    Btrfs: fix send file hole detection leading to data corruption
    (https://patchwork.kernel.org/patch/3544831/)

Signed-off-by: Filipe David Borba Manana <fdmanana@xxxxxxxxx>

Thanks for this

Reviewed-by: Josef Bacik <jbacik@xxxxxx>

Josef

<Prev in Thread] Current Thread [Next in Thread>