| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [NOISE] merge window blues, XFS broken |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 26 Jan 2014 23:41:47 -0800 |
| Cc: | "Michael L. Semon" <mlsemon35@xxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140127015614.GD2212@dastard> |
| References: | <52E56386.5040802@xxxxxxxxx> <20140127015614.GD2212@dastard> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 27, 2014 at 12:56:14PM +1100, Dave Chinner wrote: > Hmmmm - that would point to struct xfs_log_iovec being 12 bytes on > ia32, similarly the struct xfs_log_vec may not be 8 byte aligned > when allocated because pointers only require 4 byte alignement. > > Hence the initial data buffer may be 4 byte aligned and so that will > break the alignment requirement. Yeah. Shoulkd be enough to just align the initial lv_buf allocation. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | XFS: Assertion failed: fs_is_ok, file: fs/xfs/xfs_alloc.c, line: 1590, Dmitriy Yu Leonov |
|---|---|
| Next by Date: | Re: [NOISE] merge window blues, XFS broken, Michael L. Semon |
| Previous by Thread: | Re: [NOISE] merge window blues, XFS broken, Dave Chinner |
| Next by Thread: | Re: [NOISE] merge window blues, XFS broken, Michael L. Semon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |