xfs
[Top] [All Lists]

Re: [PATCH v3] xfstests: add test for btrfs incremental send infinite lo

To: Filipe David Borba Manana <fdmanana@xxxxxxxxx>, <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH v3] xfstests: add test for btrfs incremental send infinite loop issue
From: Josef Bacik <jbacik@xxxxxx>
Date: Thu, 23 Jan 2014 18:48:05 -0500
Cc: <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=message-id : date : from : mime-version : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=Bv9XLc0bwHigrxU3KzZbLjQe4nLuIXnQq8FYEd07sA4=; b=XuZIZ/AVWqLw1I7VH4vXxzOra9bgqsjwcz8bEr+1tYXEWERKeo5eTkgnWQcsKYarZAWt ouEFuR64ejEHdKV+va5U3VCef+7PVFTx4UADxwr+nZ1grXnumCX4k5Qdbwn43UcVC88v Jz33l7VQlDXJEReZwMx9AebGPyb6vf/qLFQ=
In-reply-to: <1390520280-19282-1-git-send-email-fdmanana@xxxxxxxxx>
References: <1390348610-8098-1-git-send-email-fdmanana@xxxxxxxxx> <1390520280-19282-1-git-send-email-fdmanana@xxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 01/23/2014 06:38 PM, Filipe David Borba Manana wrote:
Regression test for btrfs' incremental send feature:

1) Create several nested directories;

2) Create a read only snapshot;

3) Change the parentship of some of the deepest directories in a reverse
    way, so that parents become children and children become parents;

4) Create another read only snapshot and use it for an incremental send
    relative to the first snapshot.

At step 4 btrfs' send entered an infinite loop, increasing the memory it
used while building path strings until a krealloc was unable to allocate
more memory, which caused a warning dump in dmesg.

The following linux kernel patch fixes this issue.

    Btrfs: fix infinite path build loops in incremental send
    (https://patchwork.kernel.org/patch/3522361/)

Signed-off-by: Filipe David Borba Manana <fdmanana@xxxxxxxxx>

Reviewed-by: Josef Bacik <jbacik@xxxxxx>

Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>