xfs
[Top] [All Lists]

Re: xfsprogs 3.1.12 and 3.2.0 releases?

To: Arkadiusz MiÅkiewicz <arekm@xxxxxxxx>
Subject: Re: xfsprogs 3.1.12 and 3.2.0 releases?
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 23 Jan 2014 10:03:56 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <201401221548.52273.arekm@xxxxxxxx>
References: <201401201822.48520.arekm@xxxxxxxx> <201401210917.38674.arekm@xxxxxxxx> <20140121234151.GJ13997@dastard> <201401221548.52273.arekm@xxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jan 22, 2014 at 03:48:52PM +0100, Arkadiusz MiÅkiewicz wrote:
> On Wednesday 22 of January 2014, Dave Chinner wrote:
> > On Tue, Jan 21, 2014 at 09:17:38AM +0100, Arkadiusz MiÅkiewicz wrote:
> 
> > > By looking into git log these look like small fixes for 3.1.x. Could
> > > someone else recheck?
> > 
> > .....
> > 
> > > 3a19fb7dce9d570e78deaf5c26c0ab8a4a5bef67 libxfs: stop caching inode
> > > structures 61510437c627b529feb95ebffddd73df5ed5b104 repair: prefetching
> > > is turned off unnecessarily 0cce4aa198f0470817bedb3781ea5b6955e43076
> > > repair: Increase default repair parallelism on large filesystems
> > 
> > I think these three are not a great idea for 3.1.x. They result in
> > significant changes of behaviour that can result in increased memory
> > consumption by default. I'd prefer that we don't make changes to the
> > default behaviour in a bug-fix only point release.
> 
> 3a19fb7dce9d570e78deaf5c26c0ab8a4a5bef67 libxfs: stop caching inode
> 
> looks like wasting memory fix to me but ok.

The last paragraph ofi the commit message points out the problems
that can occur with memory consumption. For sparse inode
populations, the buffer cache can consume much more memory than the
inode cache did, and that can cause OOM problems with repair...

As it is, it is a significant change of behaviour, so for a
lightweight bug-fix only release I feel that it is out-of-scope...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>