xfs
[Top] [All Lists]

Re: [PATCH] xfstests: define $seqres in btrfs/026-029

To: Koen De Wit <koen.de.wit@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfstests: define $seqres in btrfs/026-029
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 22 Jan 2014 10:55:58 -0600
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1390404738-387-1-git-send-email-koen.de.wit@xxxxxxxxxx>
References: <1390404738-387-1-git-send-email-koen.de.wit@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
On 1/22/14, 9:32 AM, Koen De Wit wrote:
> I forgot to define $seqres in btrfs/026-029. As a result, a file named
> .full was created in the current working directory. Fix it.
> ---
>  tests/btrfs/026 |    1 +
>  tests/btrfs/027 |    1 +
>  tests/btrfs/028 |    1 +
>  tests/btrfs/029 |    1 +
>  4 files changed, 4 insertions(+), 0 deletions(-)

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

presumably we can add your signed-off-by?  ;)

I wonder if this can't be done in the common scripts:

# grep -h seqres= tests/*/??? | sort | uniq -c
    349 seqres=$RESULT_DIR/$seq

rather than doing it in every single test ...

-Eric

> 
> diff --git a/tests/btrfs/026 b/tests/btrfs/026
> index bf6f528..6c54590 100644
> --- a/tests/btrfs/026
> +++ b/tests/btrfs/026
> @@ -26,6 +26,7 @@
>  #
>  
>  seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
>  echo "QA output created by $seq"
>  
>  here=`pwd`
> diff --git a/tests/btrfs/027 b/tests/btrfs/027
> index d76bb0f..b2dff1c 100644
> --- a/tests/btrfs/027
> +++ b/tests/btrfs/027
> @@ -26,6 +26,7 @@
>  #-----------------------------------------------------------------------
>  
>  seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
>  echo "QA output created by $seq"
>  
>  here=`pwd`
> diff --git a/tests/btrfs/028 b/tests/btrfs/028
> index 06d2faf..f17f102 100644
> --- a/tests/btrfs/028
> +++ b/tests/btrfs/028
> @@ -24,6 +24,7 @@
>  #-----------------------------------------------------------------------
>  
>  seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
>  echo "QA output created by $seq"
>  
>  here=`pwd`
> diff --git a/tests/btrfs/029 b/tests/btrfs/029
> index 1fd2a93..b93b6df 100644
> --- a/tests/btrfs/029
> +++ b/tests/btrfs/029
> @@ -29,6 +29,7 @@
>  #-----------------------------------------------------------------------
>  
>  seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
>  echo "QA output created by $seq"
>  
>  here=`pwd`
> 

<Prev in Thread] Current Thread [Next in Thread>