xfs
[Top] [All Lists]

Re: [PATCH RESEND] xfstests: btrfs: cross-subvolume sparse copy

To: Koen De Wit <koen.de.wit@xxxxxxxxxx>
Subject: Re: [PATCH RESEND] xfstests: btrfs: cross-subvolume sparse copy
From: David Sterba <dsterba@xxxxxxx>
Date: Wed, 22 Jan 2014 14:27:29 +0100
Cc: xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1390304448-25752-1-git-send-email-koen.de.wit@xxxxxxxxxx>
Mail-followup-to: dsterba@xxxxxxx, Koen De Wit <koen.de.wit@xxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
References: <1390304448-25752-1-git-send-email-koen.de.wit@xxxxxxxxxx>
Reply-to: dsterba@xxxxxxx
User-agent: Mutt/1.5.22 (2013-10-16)
On Tue, Jan 21, 2014 at 12:40:48PM +0100, Koen De Wit wrote:
> +btrfs subvol delete $SUBVOL1 >/dev/null 2>&1
> +btrfs subvol delete $SUBVOL2 >/dev/null 2>&1

Please use $BTRFS_UTIL_PROG instead of 'btrfs' and don't shorten the
command names, ie 'subvolume'.

> +cp --reflink $TESTDIR1/file1 $SUBVOL1
> +cp --reflink $TESTDIR1/file1 $SUBVOL2
> +cp --reflink $SUBVOL1/file2 $TESTDIR1/
> +cp --reflink $SUBVOL1/file2 $SUBVOL2
> +cp --reflink $SUBVOL2/file3 $TESTDIR1/
> +cp --reflink $SUBVOL2/file3 $SUBVOL1

--reflink without any parameter means 'always', that's what we want, but
can we possibly make it explicit? 'cp' is an external tool and if the
default changes, the test would not work as expected.

Otherwise ok,
Reviewed-by: David Sterba <dsterba@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>