xfs
[Top] [All Lists]

Re: [PATCH] xfs/199: enforce v4 superblock format for test

To: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfs/199: enforce v4 superblock format for test
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Wed, 22 Jan 2014 17:53:07 +0800
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1390302628-19020-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1390302628-19020-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 01/21 2014 19:10 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> This test relies of the contents of the sb_features2 field being
> known. Make sure ot clear allt eh MKFS_OPTIONS and ensure that we
> direct mkfs to create only the simplest of featuresets to test this
> functionality.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  tests/xfs/199 | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/199 b/tests/xfs/199
> index 1d64e02..c1b5962 100755
> --- a/tests/xfs/199
> +++ b/tests/xfs/199
> @@ -49,7 +49,10 @@ _supported_os Linux
>  
>  _require_scratch
>  
> -_scratch_mkfs_xfs -l lazy-count=1 >/dev/null 2>&1
> +# clear any mkfs options so taht we can directly specify the options we need 
> to
                                ^^^
                                a typo...
> +# be able to test the features bitmask behaviour correctly.
> +MKFS_OPTIONS=
> +_scratch_mkfs_xfs -l lazy-count=1 -i projid32bit=0 >/dev/null 2>&1
>  
>  #
>  # Print the current flags.  Just a dummy so that the test breaks

Looks good to me.

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>


Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>