xfs
[Top] [All Lists]

Re: [RFC] unifying write variants for filesystems

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [RFC] unifying write variants for filesystems
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 20 Jan 2014 12:32:01 -0800
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Sage Weil <sage@xxxxxxxxxxx>, Steve French <sfrench@xxxxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=OshosBUUA7+J5IF7npHEeeD2HuhVdjqxXKuhihD1uJc=; b=NkPS5Cq42W9gHArkkTHr5GZCSFCAa2oi1lTA1rkIk5FIxJHEgoiUNbVBm85eJhLupp 2LIR1HW2serPs4PvgDH1Idp3xwqu8H8kaMWX5jom1b0LvqbW2Dxd5NjkY8AfISovZ7Ly oNeH1pe8pG4ZFh+fLdeNAWpjzW6IHESd/Ad5noBjlEK7KrPw94fOlsDPKlCIYOASvelo ZPH8fT57RWnH3RZ6gJFdLLBFfypzN0k5oDvVixy2L/0Jc/SflUOMzA1Umq4piCWPTi9I qVR8frKZPTZMJ+KqBR9Cwgygjx646ITmRpjUi61pZBOSo5ExBcCiktZ4u1YBvMMEbXWh duAg==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=OshosBUUA7+J5IF7npHEeeD2HuhVdjqxXKuhihD1uJc=; b=fJ62vEGfwawfJLM/a6Dho0xN7JFlnBWWaTXbWt1xg1dSWLfWrhgWMx+WsXbLOUljPO kFuSs4mehp4SAZ8UMNv//zYqER9AmfzTBrfdiMSgWQm8xFfuj4azbwskb4nNds1hhc9d VNa7XDYlDIGF1Zp+V9SoGjGwkdOQTwe0szdP0=
In-reply-to: <20140120135514.GA21567@xxxxxxxxxxxxx>
References: <20140113141416.GA30117@xxxxxxxxxxxxx> <20140113235646.GR10323@xxxxxxxxxxxxxxxxxx> <20140114132207.GA25170@xxxxxxxxxxxxx> <20140114172033.GU10323@xxxxxxxxxxxxxxxxxx> <20140118064040.GE10323@xxxxxxxxxxxxxxxxxx> <CA+55aFw4LgyYEkygxHUnpKZg3jMACGzsyENc9a9rWFmLcaRefQ@xxxxxxxxxxxxxx> <20140118074649.GF10323@xxxxxxxxxxxxxxxxxx> <CA+55aFzM0N7WjqnLNnuqTkbj3iws9f3bYxei=ZBCM8hvps4zYg@xxxxxxxxxxxxxx> <20140118201031.GI10323@xxxxxxxxxxxxxxxxxx> <20140119051335.GN10323@xxxxxxxxxxxxxxxxxx> <20140120135514.GA21567@xxxxxxxxxxxxx>
Sender: linus971@xxxxxxxxx
On Mon, Jan 20, 2014 at 5:55 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Sun, Jan 19, 2014 at 05:13:35AM +0000, Al Viro wrote:
>> Folks, what do you think about the following:
>
> That's very much what Shaggy did in the aio-direct tree, except that
> it kept using a single set of methods.  Linus really didn't like it
> unfortunately.

Umm. That wasn't what I objected to.

I objected to the incredibly ugly implementation, the crazy new flags
arguments for core helper functions, ugly naming etc etc. I even
outlined what might fix it.

In other words, I thought the code was shit and ugly. Not that
iterators per se would be wrong. Just doing them badly is wrong.

So don't go putting words in my mouth. It isn't "unfortunate" at all
that I have higher quality standards.

          Linus

<Prev in Thread] Current Thread [Next in Thread>