xfs
[Top] [All Lists]

Re: [PATCH 3/5] xfstests: don't suggest to run full diff when DIFF_LENGT

To: David Sterba <dsterba@xxxxxxx>
Subject: Re: [PATCH 3/5] xfstests: don't suggest to run full diff when DIFF_LENGTH is 0
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 20 Jan 2014 13:25:14 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <49b0cf305ade3444c3dcf3fbabb5e1e5e720c16d.1389891730.git.dsterba@xxxxxxx>
References: <cover.1389891730.git.dsterba@xxxxxxx> <49b0cf305ade3444c3dcf3fbabb5e1e5e720c16d.1389891730.git.dsterba@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jan 16, 2014 at 06:07:13PM +0100, David Sterba wrote:
> If DIFF_LENGTH is set to 0, the full output is available and the message
> does not make sense.
> 
> Signed-off-by: David Sterba <dsterba@xxxxxxx>
> ---
>  check | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/check b/check
> index 9e4275b1fa37..d578e49b78d4 100755
> --- a/check
> +++ b/check
> @@ -510,11 +510,11 @@ do
>                               cat
>                       else
>                               head -n "$DIFF_LENGTH"
> +                             echo "..."
> +                             echo "(Run '$diff $seq.out $seqres.out.bad'"
> +                                     " to see the entire diff)"

You're missing a trailing "\" there. Even simple patches need
testing. ;)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>