xfs
[Top] [All Lists]

Re: [PATCH 0/5] splice: locking changes and code refactoring

To: viro@xxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 0/5] splice: locking changes and code refactoring
From: David Miller <davem@xxxxxxxxxxxxx>
Date: Sat, 18 Jan 2014 00:44:53 -0800 (PST)
Cc: torvalds@xxxxxxxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, axboe@xxxxxxxxx, mfasheh@xxxxxxxx, jlbec@xxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, sage@xxxxxxxxxxx, sfrench@xxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140118082730.GH10323@xxxxxxxxxxxxxxxxxx>
References: <CA+55aFw4LgyYEkygxHUnpKZg3jMACGzsyENc9a9rWFmLcaRefQ@xxxxxxxxxxxxxx> <20140118074649.GF10323@xxxxxxxxxxxxxxxxxx> <20140118082730.GH10323@xxxxxxxxxxxxxxxxxx>
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Sat, 18 Jan 2014 08:27:30 +0000

> BTW, would sockets benefit from having ->sendpages() that would take an
> array of (page, offset, len) triples?  It would be trivial to do and
> some of the helpers that are falling out of writing that writev-based
> default_file_splice_write() look like they could be reused for
> calling that one...  Dave?

That's originally how the sendpage method was implemented, but back then
Linus asked us to only pass one page at a time.

I don't remember the details beyond that.

<Prev in Thread] Current Thread [Next in Thread>