xfs
[Top] [All Lists]

Re: [PATCH 0/5] splice: locking changes and code refactoring

To: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 0/5] splice: locking changes and code refactoring
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 17 Jan 2014 23:22:04 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Sage Weil <sage@xxxxxxxxxxx>, Steve French <sfrench@xxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=9v/vtbCTYXqBxr8ZeE18g05dZGGV5TRULOHJAfZmLxg=; b=RqxDEQ2JWnhvpEHDLzpSMuN1W5nmwA76XDBgVPLX2RjidBeE/9VkN6cX11X21yvOqf zbG55Ea/GZPVrWG9/bPc4mgffNsidUmIXgLkyQpHG/GIiGJkVlzIiYDHd8Fn1xUQwlNk ZW0LuscM6BQbSM6w+RxgWD+2gpQNeMvGJ8zU3hVWHcbtd0WYZ+fu/U2xezCNIhwv3SnP GqGnY3OzTx9oS+GW3AkyMAKvOHHMzZjDK+8yyfu0SbF1HpLqN/rxms3t2XtMGO7IMTXc WQplZK79VavNvh59PPJdt82On1JyxqVZWSXid8n0SfLMvhHwMB6e1MVQ8DOAtBrEuDMn g/sQ==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=9v/vtbCTYXqBxr8ZeE18g05dZGGV5TRULOHJAfZmLxg=; b=B9tDlG9XhzHS6qgi+mOEBrm/MS1DeeO8TKp/HSfcHNJTlCgL9GjL7CqGbMNyc+N2yn nXaKMZkFKuC637s0MXM78BEuWNSEYx0VAiUu6C+z3XHsA6ELJxD+037bqoWAfgcOMakr G+dtB29i2BC5aLOI5k2p2ppXanznrJaAWNYUM=
In-reply-to: <20140118064040.GE10323@xxxxxxxxxxxxxxxxxx>
References: <20131212181459.994196463@xxxxxxxxxxxxxxxxxxxxxx> <20140113141416.GA30117@xxxxxxxxxxxxx> <20140113235646.GR10323@xxxxxxxxxxxxxxxxxx> <20140114132207.GA25170@xxxxxxxxxxxxx> <20140114172033.GU10323@xxxxxxxxxxxxxxxxxx> <20140118064040.GE10323@xxxxxxxxxxxxxxxxxx>
Sender: linus971@xxxxxxxxx
On Fri, Jan 17, 2014 at 10:40 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> Objections, comments?

I certainly object to the "map, then unmap" approach. No VM games.

But if it can be done more naturally as a writev, then that may well
be ok. As long as we're talking about just the
default_file_splice_write() case, and people who want to do special
things with page movement can continue to do so..

              Linus

<Prev in Thread] Current Thread [Next in Thread>