xfs
[Top] [All Lists]

Re: [PATCH 2/3] xfs: rename xfs_buftarg structure members

To: Roger Willcocks <roger@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] xfs: rename xfs_buftarg structure members
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 17 Jan 2014 15:13:23 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1389993137.4298.938.camel@xxxxxxxxxxxxxxxxxxxxx>
References: <52D6CC91.6000408@xxxxxxxxxx> <52D9910C.9000205@xxxxxxxxxxx> <52D991E5.1010300@xxxxxxxxxxx> <1389993137.4298.938.camel@xxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
On 1/17/14, 3:12 PM, Roger Willcocks wrote:
> - if ((pos & target->bt_smask) || (size & target->bt_smask)) {
> + if ((pos || size) & target->bt_meta_sectormask) {
> 
> nope...
> 
> || needs to be |
> 
> (pos || size) yields a boolean
> 
> 
> 
>  
> Roger Willcocks <roger@xxxxxxxxxxxxxxxx>
> 


Oof.  Brain fart.  Thank you :)

<Prev in Thread] Current Thread [Next in Thread>