xfs
[Top] [All Lists]

Re: [PATCH] xfs: use tr_growrtalloc for growing rt files

To: Brian Foster <bfoster@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfs: use tr_growrtalloc for growing rt files
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 17 Jan 2014 14:52:41 -0600
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1389989370-12159-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1389989370-12159-1-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
On 1/17/14, 2:09 PM, Brian Foster wrote:
> This is a regression from the following commit:
> 
> 3d3c8b5222b9 xfs: refactor xfs_trans_reserve() interface
> 
> Use the tr_growrtalloc log reservation for growing the
> bitmap/summary files.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Looks right to me.  :)

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> ---
>  fs/xfs/xfs_rtalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index a6a76b2..ec5ca65 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -842,7 +842,7 @@ xfs_growfs_rt_alloc(
>               /*
>                * Reserve space & log for one extent added to the file.
>                */
> -             error = xfs_trans_reserve(tp, &M_RES(mp)->tr_growdata,
> +             error = xfs_trans_reserve(tp, &M_RES(mp)->tr_growrtalloc,
>                                         resblks, 0);
>               if (error)
>                       goto error_cancel;
> 

<Prev in Thread] Current Thread [Next in Thread>