xfs
[Top] [All Lists]

Re: [PATCH] xfstests: kill lib/random.c

To: Chris Mason <clm@xxxxxx>
Subject: Re: [PATCH] xfstests: kill lib/random.c
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 13 Jan 2014 12:56:58 +1100
Cc: Josef Bacik <jbacik@xxxxxx>, "sandeen@xxxxxxxxxx" <sandeen@xxxxxxxxxx>, "bpm@xxxxxxx" <bpm@xxxxxxx>, "sandeen@xxxxxxxxxxx" <sandeen@xxxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1389129641.23310.20.camel@xxxxxxxxxxxxxxxxxxx>
References: <1389038323-8304-1-git-send-email-jbacik@xxxxxx> <52CB20ED.1010705@xxxxxxxxxx> <52CB2336.2060009@xxxxxx> <52CB2452.70507@xxxxxxxxxx> <20140107200135.GD1935@xxxxxxx> <52CC5F27.1090602@xxxxxxxxxxx> <20140107204015.GJ10553@xxxxxxx> <52CC6F00.3060907@xxxxxx> <1389129641.23310.20.camel@xxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jan 07, 2014 at 09:20:12PM +0000, Chris Mason wrote:
> On Tue, 2014-01-07 at 16:17 -0500, Josef Bacik wrote:
> > On 01/07/2014 03:40 PM, Ben Myers wrote:
> > > On Tue, Jan 07, 2014 at 02:10:15PM -0600, Eric Sandeen wrote:
> > >> On 1/7/14, 2:01 PM, Ben Myers wrote:
> > >>> Hey Gents,
> > >>>
> > >>> On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote:
> > >>>> On 1/6/14, 3:42 PM, Josef Bacik wrote:
> > >>>>> On 01/06/2014 04:32 PM, Eric Sandeen wrote:
> > >>>>>> On 1/6/14, 1:58 PM, Josef Bacik wrote:
> > >>>>>>> I was trying to reproduce something with fsx and I noticed that no 
> > >>>>>>> matter what
> > >>>>>>> seed I set I was getting the same file.  Come to find out we are 
> > >>>>>>> overloading
> > >>>>>>> random() with our own custom horribleness for some unknown reason.  
> > >>>>>>> So nuke the
> > >>>>>>> damn thing from orbit and rely on glibc's random().  With this fix 
> > >>>>>>> the -S option
> > >>>>>>> actually does something with fsx.  Thanks,
....
> For now we can just use srandom?

Seems to me like it will solve the problem. Josef?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>