| To: | Jeff Liu <jeff.liu@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [xfs] c91c46c12: xfstests generic/313 regression |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sat, 11 Jan 2014 03:10:45 -0800 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, fengguang.wu@xxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <52CFFD1C.7050005@xxxxxxxxxx> |
| References: | <20140110122700.GA12624@localhost> <52CFF402.5080409@xxxxxxxxxx> <20140110133306.GA22918@xxxxxxxxxxxxx> <52CFFD1C.7050005@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Jan 10, 2014 at 10:01:00PM +0800, Jeff Liu wrote: > I also thought to fix this problem in this way, however I'm not sure > if those flags can be set back to iattr->ia_valid internally... > > Otherwise, this fix looks good to me. Nothing in the truncate or open code path (or non-size setattr for that matter) looks at ia_valid after calling the filesystem, and they really have no business to. In the meantime this has passed xfstests, so I'll send it along. Thanks for the first fix, btw! |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] vfs: Fix possible NULL pointer dereference in inode_permission(), Christoph Hellwig |
|---|---|
| Next by Date: | Re: china supplier for toner chips, PCC |
| Previous by Thread: | Re: [xfs] c91c46c12: xfstests generic/313 regression, Jeff Liu |
| Next by Thread: | Re: [xfs] c91c46c12: xfstests generic/313 regression, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |