xfs
[Top] [All Lists]

Re: [PATCH] xfs: require 64-bit sector_t

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: require 64-bit sector_t
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 9 Jan 2014 09:19:03 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131216221559.GO1935@xxxxxxx>
References: <20131114164603.GA13628@xxxxxxxxxxxxx> <20131216221559.GO1935@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Dec 16, 2013 at 04:15:59PM -0600, Ben Myers wrote:
> Hey Christoph,
> 
> On Thu, Nov 14, 2013 at 08:46:03AM -0800, Christoph Hellwig wrote:
> > Trying to support tiny disks only and saving a bit memory might have
> > made sense on an SGI O2 15 years ago, but is pretty pointless today.
> > 
> > Remove the rarely tested codepath that uses various smaller in-memory
> > types to reduce our test matrix and make the codebase a little bit
> > smaller and less complicated.
> > 
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> This looks ok to me.  I'm not seeing much downside to removing the smaller
> in-memory types.
> 
> Reviewed-by: Ben Myers <bpm@xxxxxxx>

Anyone else have an opinion on this one?  I think its 3.14 material and I'd
like to pull it in.

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>