xfs
[Top] [All Lists]

Re: [PATCH 2/3] xfs: Calling destroy_work_on_stack() to pair with INIT_W

To: Chuansheng Liu <chuansheng.liu@xxxxxxxxx>, dchinner@xxxxxxxxxxxxx, bpm@xxxxxxx
Subject: Re: [PATCH 2/3] xfs: Calling destroy_work_on_stack() to pair with INIT_WORK_ONSTACK()
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 07 Jan 2014 19:21:05 +0800
Cc: linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1389084814.3650.70.camel@cliu38-desktop-build>
References: <1389084605.3650.66.camel@cliu38-desktop-build> <1389084814.3650.70.camel@cliu38-desktop-build>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
Hi Chuansheng,

On 01/07 2014 16:53 PM, Chuansheng Liu wrote:
> 
> In case CONFIG_DEBUG_OBJECTS_WORK is defined, it is needed to
> call destroy_work_on_stack() which frees the debug object to pair
> with INIT_WORK_ONSTACK().
> 
> Signed-off-by: Liu, Chuansheng <chuansheng.liu@xxxxxxxxx>
> ---
>  fs/xfs/xfs_bmap_util.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
> index 1394106..82e0dab 100644
> --- a/fs/xfs/xfs_bmap_util.c
> +++ b/fs/xfs/xfs_bmap_util.c
> @@ -287,6 +287,7 @@ xfs_bmapi_allocate(
>       INIT_WORK_ONSTACK(&args->work, xfs_bmapi_allocate_worker);
>       queue_work(xfs_alloc_wq, &args->work);
>       wait_for_completion(&done);
> +     destroy_work_on_stack(&args->work);
>       return args->result;
>  }

Thanks for your patch and it work fine for my testing.  I missed this in an
old commit: [ 3b876c8f2a xfs: fix debug_object WARN at xfs_alloc_vextent() ] 

Just out of curious, do you notice memory leaks or other hints which help you
finding out this problem?   

Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>