xfs
[Top] [All Lists]

Re: [PATCH 6/10] xfs: introduce xfs_bulkstat_ichunk_ra

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 6/10] xfs: introduce xfs_bulkstat_ichunk_ra
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 31 Dec 2013 17:46:13 +0800
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52C1A5F7.2040604@xxxxxxx>
References: <52BEB459.7020202@xxxxxxxxxx> <52C1A5F7.2040604@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 2013å12æ31æ 00:57, Mark Tinguely wrote:
> On 12/28/13 05:22, Jeff Liu wrote:
>> From: Jie Liu<jeff.liu@xxxxxxxxxx>
>>
>> Introduce xfs_bulkstat_ichunk_ra() to loop over all clusters in
>> the next inode chunk, then performs readahead if there are any
>> allocated inodes in that cluster.
>>
>> Refactor xfs_bulkstat() with it.
>>
>> Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
>> ---
> 
> Had some problems applying this patch.
> ...
> 
>> +STATIC void
>> +xfs_bulkstat_ichunk_ra(
>> +    struct xfs_mount        *mp,
>> +    xfs_agnumber_t            agno,
>> +    struct xfs_inobt_rec_incore    *irec)
>> +{
>> +    xfs_agblock_t            agbno;
>> +    struct blk_plug            plug;
>> +    int                blks_per_cluster;
>> +    int                inodes_per_cluster;
>> +    int                i;    /* inode chunk index */
>> +
>> +    agbno = XFS_AGINO_TO_AGBNO(mp, irec->ir_startino);
>> +    blks_per_cluster = xfs_icluster_size_fsb(mp);
>                            ^^^^^
> does not exist.
This patch series is based on my previous code refactoring of
introducing xfs_icluster_size_fsb() helper.  I guess you would
apply this patch on top of that without the current problems.

Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>