[Top] [All Lists]

Re: [PATCH 2/10] xfs: xfs_bulkstat_single consolidation

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH 2/10] xfs: xfs_bulkstat_single consolidation
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 30 Dec 2013 12:35:17 -0600
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52BEB3E7.2080706@xxxxxxxxxx>
References: <52BEB3E7.2080706@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 12/28/13 05:20, Jeff Liu wrote:
From: Jie Liu<jeff.liu@xxxxxxxxxx>

In xfs_bulkstat_single(), xfs_bulkstat_one() and xfs_bulkstat() might
return different error if either call failed, we'd better return the
proper error in this case.  Moreover, the function argument done is
useless in terms of xfs_ioc_bulkstat(), hence we can get rid of it.

Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>

Yes, I know dmapi is not loved here but SGI still uses it and it wants the done flag still.


<Prev in Thread] Current Thread [Next in Thread>