xfs
[Top] [All Lists]

Re: [PATCH v2 2/3] xfs: add O_TMPFILE support

To: Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2 2/3] xfs: add O_TMPFILE support
From: Zhi Yong Wu <zwu.kernel@xxxxxxxxx>
Date: Tue, 24 Dec 2013 09:58:02 +0800
Cc: xfstests <xfs@xxxxxxxxxxx>, Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=XFlrVGm65Cy6blBxmQ/ax4t9p+MIOBLukaEsyiokUKY=; b=IEEVjn0Kj4N7fDqOg31JMcLo8h02ecD7yBPpVn/T9kcLJOUiAKErfj+ugj6h4BekQK i6UXxlOTH9xh1ps3ZPhKVmAIMPecnSluCCS9Mm2wUxoq4AZMDBTXsuWd+nh8vGHWh4Es eSLqHvFAjxUhKYl2WEZojwEs0Vl2rZF2d48kNJaTLa3Jna8a09US7esVJxiHaoRuU1s/ KMovoG2uQhz4+d8Z47fzORo1Wnww2bK8+mq19Euwno9m5cQI73q2TU9HN9KHv2vgwpun uWe3T8PPzx6x11ZcapylNhc83iji+ZpokkqhGUxqEB1R7JdEcr0AsCL++aFm6ZzSy0PN a8hw==
In-reply-to: <20131224005506.GL3220@dastard>
References: <1387326161-24530-1-git-send-email-zwu.kernel@xxxxxxxxx> <1387326161-24530-3-git-send-email-zwu.kernel@xxxxxxxxx> <20131224005506.GL3220@dastard>
On Tue, Dec 24, 2013 at 8:55 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> On Wed, Dec 18, 2013 at 08:22:40AM +0800, Zhi Yong Wu wrote:
>> From: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>
>>
>> Add two functions xfs_create_tmpfile() and xfs_vn_tmpfile()
>> to support O_TMPFILE file creation.
>>
>> In contrast to xfs_create(), xfs_create_tmpfile() has a different
>> log reservation to the regular file creation because there is no
>> directory modification, and doesn't check if an entry can be added
>> to the directory, but the reservation quotas is required appropriately,
>> and finally its inode is added to the unlinked list.
>>
>> xfs_vn_tmpfile() add one O_TMPFILE method to VFS interface and directly
>> invoke xfs_create_tmpfile().
>
> There's minor stuff I could ask you to change, but I think this is
> good enough for initial support of O_TMPFILE.
>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Great, thanks a lot for your amazing Chrismas gift. Dave and
Christoph, Merry Chrismas!

>
> --
> Dave Chinner
> david@xxxxxxxxxxxxx



-- 
Regards,

Zhi Yong Wu

<Prev in Thread] Current Thread [Next in Thread>