[Top] [All Lists]

Re: [PATCH v2 2/3] xfs: add O_TMPFILE support

To: Zhi Yong Wu <zwu.kernel@xxxxxxxxx>
Subject: Re: [PATCH v2 2/3] xfs: add O_TMPFILE support
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 24 Dec 2013 11:55:06 +1100
Cc: xfs@xxxxxxxxxxx, Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1387326161-24530-3-git-send-email-zwu.kernel@xxxxxxxxx>
References: <1387326161-24530-1-git-send-email-zwu.kernel@xxxxxxxxx> <1387326161-24530-3-git-send-email-zwu.kernel@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Dec 18, 2013 at 08:22:40AM +0800, Zhi Yong Wu wrote:
> From: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>
> Add two functions xfs_create_tmpfile() and xfs_vn_tmpfile()
> to support O_TMPFILE file creation.
> In contrast to xfs_create(), xfs_create_tmpfile() has a different
> log reservation to the regular file creation because there is no
> directory modification, and doesn't check if an entry can be added
> to the directory, but the reservation quotas is required appropriately,
> and finally its inode is added to the unlinked list.
> xfs_vn_tmpfile() add one O_TMPFILE method to VFS interface and directly
> invoke xfs_create_tmpfile().

There's minor stuff I could ask you to change, but I think this is
good enough for initial support of O_TMPFILE.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>