xfs
[Top] [All Lists]

Re: [PATCH 04/11 v2] xfs: add xfs_ilock_attr_map_shared

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/11 v2] xfs: add xfs_ilock_attr_map_shared
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 18 Dec 2013 15:47:59 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131218101439.GA5060@xxxxxxxxxxxxx>
References: <20131206203006.914776999@xxxxxxxxxxxxxxxxxxxxxx> <20131206203128.663030833@xxxxxxxxxxxxxxxxxxxxxx> <20131208223610.GE31386@dastard> <20131209181612.GA22183@xxxxxxxxxxxxx> <20131209222433.GY10988@dastard> <20131210161349.GD19510@xxxxxxxxxxxxx> <20131217173334.GV1935@xxxxxxx> <20131218101439.GA5060@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Dec 18, 2013 at 02:14:39AM -0800, Christoph Hellwig wrote:
> Equivalent to xfs_ilock_data_map_shared, except for the attribute fork.
> 
> Make xfs_getbmap use it if called for the attribute fork instead of
> xfs_ilock_data_map_shared.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: xfs/fs/xfs/xfs_bmap_util.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_bmap_util.c   2013-12-18 11:14:52.587953376 +0100
> +++ xfs/fs/xfs/xfs_bmap_util.c        2013-12-18 11:15:29.367952621 +0100
> @@ -617,22 +617,27 @@ xfs_getbmap(
>               return XFS_ERROR(ENOMEM);
>  
>       xfs_ilock(ip, XFS_IOLOCK_SHARED);
> -     if (whichfork == XFS_DATA_FORK && !(iflags & BMV_IF_DELALLOC)) {
> -             if (ip->i_delayed_blks || XFS_ISIZE(ip) > ip->i_d.di_size) {
> +     if (whichfork == XFS_DATA_FORK) {
> +             if (!(iflags & BMV_IF_DELALLOC) &&
> +                 (ip->i_delayed_blks || XFS_ISIZE(ip) > ip->i_d.di_size)) {
>                       error = -filemap_write_and_wait(VFS_I(ip)->i_mapping);
>                       if (error)
>                               goto out_unlock_iolock;
> +
> +                     /*
> +                      * Even after flushing the inode, there can still be
> +                      * delalloc blocks on the inode beyond EOF due to
> +                      * speculative preallocation.  These are not removed

This one has a 'p'.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>