xfs
[Top] [All Lists]

Re: [PATCH v2 02/12] xfstests: _scratch_mkfs_sized() for tmpfs

To: Junho Ryu <jayr@xxxxxxxxxx>
Subject: Re: [PATCH v2 02/12] xfstests: _scratch_mkfs_sized() for tmpfs
From: Boris Ranto <branto@xxxxxxxxxx>
Date: Wed, 18 Dec 2013 00:33:42 -0500 (EST)
Cc: xfs@xxxxxxxxxxx, hughd@xxxxxxxxxx, tytso@xxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1387318722-3050-2-git-send-email-jayr@xxxxxxxxxx>
References: <1387318722-3050-1-git-send-email-jayr@xxxxxxxxxx> <1387318722-3050-2-git-send-email-jayr@xxxxxxxxxx>
Thread-index: 8IB9dIUgi6tifIZE8jf/F6UWCWQE4w==
Thread-topic: xfstests: _scratch_mkfs_sized() for tmpfs
Same here, the patch uses -d instead of -b option.

----- Original Message -----
> From: Hugh Dickins <hughd@xxxxxxxxxx>
> 
> _scratch_mkfs_sized() avoid blockdev and update MOUNT_OPTIONS with
> required size on tmpfs, so those tests using it can now run.
> 
> Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>
> Signed-off-by: Junho Ryu <jayr@xxxxxxxxxx>
> ---
> 
> v2: same as v1
> 
>  common/rc | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/common/rc b/common/rc
> index a2005c9..c78356e 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -590,7 +590,7 @@ _scratch_mkfs_sized()
>  
>      blocks=`expr $fssize / $blocksize`
>  
> -    if [ "$HOSTOS" == "Linux" ]; then
> +    if [ "$HOSTOS" == "Linux" -a -d "$SCRATCH_DEV" ]; then
>       devsize=`blockdev --getsize64 $SCRATCH_DEV`
>       [ "$fssize" -gt "$devsize" ] && _notrun "Scratch device too small"
>      fi
> @@ -611,6 +611,9 @@ _scratch_mkfs_sized()
>      btrfs)
>       $MKFS_BTRFS_PROG $MKFS_OPTIONS -b $fssize $SCRATCH_DEV
>       ;;
> +    tmpfs)
> +     export MOUNT_OPTIONS="-o size=$fssize $TMPFS_MOUNT_OPTIONS"
> +     ;;
>      *)
>       _notrun "Filesystem $FSTYP not supported in _scratch_mkfs_sized"
>       ;;
> --
> 1.8.5.1
> 
> 

<Prev in Thread] Current Thread [Next in Thread>