xfs
[Top] [All Lists]

Re: [PATCH v2 09/12] xfstests: skip generic/076 which cannot work on tmp

To: Junho Ryu <jayr@xxxxxxxxxx>
Subject: Re: [PATCH v2 09/12] xfstests: skip generic/076 which cannot work on tmpfs
From: Boris Ranto <branto@xxxxxxxxxx>
Date: Wed, 18 Dec 2013 00:20:29 -0500 (EST)
Cc: xfs@xxxxxxxxxxx, hughd@xxxxxxxxxx, tytso@xxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1387318722-3050-9-git-send-email-jayr@xxxxxxxxxx>
References: <1387318722-3050-1-git-send-email-jayr@xxxxxxxxxx> <1387318722-3050-9-git-send-email-jayr@xxxxxxxxxx>
Thread-index: rDsY1EAYilXC4mngMFjQeWIX7Fwg6w==
Thread-topic: xfstests: skip generic/076 which cannot work on tmpfs
Hi,

here, you were probably looking for -b option (that tests if its argument is a 
block device) instead of -d option (that tests if its argument is a directory). 
Otherwise, this patch would skip the test case for an arbitrary file system.

-Boris

----- Original Message -----
> Skip generic/076 which tests concurrent access while testing tmpfs
> because there are other tests cover the case using fsstress.
> 
> Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
> Signed-off-by: Junho Ryu <jayr@xxxxxxxxxx>
> ---
> 
> v2: check whether SCRATCH_DEV is a block device instead of checking whether
>     FSTYP is tmpfs.
> 
>  tests/generic/076 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/generic/076 b/tests/generic/076
> index a53840f..7ab2fbc 100755
> --- a/tests/generic/076
> +++ b/tests/generic/076
> @@ -57,6 +57,8 @@ _supported_os IRIX Linux
>  
>  _require_scratch
>  
> +[ -d "$SCRATCH_DEV" ] || _notrun "this test requires block device"
> +
>  echo "*** init fs"
>  
>  rm -f $seqres.full
> --
> 1.8.5.1
> 
> 

<Prev in Thread] Current Thread [Next in Thread>