xfs
[Top] [All Lists]

Re: [PATCH 1/3] common: Filter out lost+found directory from _ls_l() out

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 1/3] common: Filter out lost+found directory from _ls_l() output
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Tue, 17 Dec 2013 14:22:36 -0200
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1387288947-12650-1-git-send-email-lczerner@xxxxxxxxxx>
Mail-followup-to: xfs@xxxxxxxxxxx
References: <1387288947-12650-1-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Hi Lukas,

I guess this patchset lacks a cover letter you might have forgotten to add?
despite the first patch which is easier to understand the reason due the
comment you added to the own patch, the purpose of the remaining patches are
not clear.


On Tue, Dec 17, 2013 at 03:02:25PM +0100, Lukas Czerner wrote:
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
> ---
>  common/rc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/common/rc b/common/rc
> index 5f61d57..7a168e9 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -74,10 +74,11 @@ _md5_checksum()
>  
>  # ls -l w/ selinux sometimes puts a dot at the end:
>  # -rwxrw-r--. id1 id2 file1
> +# Also filter out lost+found directory on extN file system if present
>  
>  _ls_l()
>  {
> -     ls -l $* | sed "s/\(^[-rwxdlbcpsStT]*\)\. /\1 /"
> +     ls -l $* | sed "s/\(^[-rwxdlbcpsStT]*\)\. /\1 /" | grep -v 'lost+found'
>  }
>  
>  _mount_opts()
> -- 
> 1.8.3.1
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Carlos

<Prev in Thread] Current Thread [Next in Thread>