[Top] [All Lists]

Re: [RFC] Handling of reviewed patch series

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [RFC] Handling of reviewed patch series
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 17 Dec 2013 14:54:04 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131216233940.GR1935@xxxxxxx>
References: <20131213053611.GQ10988@dastard> <20131213185618.GJ1935@xxxxxxx> <20131213231401.GZ10988@dastard> <20131216233940.GR1935@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Dec 16, 2013 at 05:39:40PM -0600, Ben Myers wrote:
> Hi Dave,
> On Sat, Dec 14, 2013 at 10:14:01AM +1100, Dave Chinner wrote:
> > On Fri, Dec 13, 2013 at 12:56:18PM -0600, Ben Myers wrote:
> > > > Anyway, have a think and discuss - I'm going to push the
> > > > branches I mentioned above....
> > > 
> > > I've been tracking message id and patchwork id in git notes along
> > > with commits for awhile.  I'm hoping this will become useful later
> > > for cross referencing the list, patchworks, and test results.  If
> > > you wouldn't mind also doing so I'd appreciate it.  Maybe it could
> > > be done with a post-commit script or something.
> > 
> > There's no notes in the repo of oss.sgi.com, so I'm not sure what
> > you are doing here.
> I'm just trying to track the message id along with patchwork id.  Maybe later 
> I
> can script it up so that test results are cross referenced with the list 
> archives.
> commit c91c46c12768daac8486dff0f74bc52c2ec974cd
> Author: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Date:   Mon Nov 18 05:10:52 2013 -0800
>     xfs: add xfs_setattr_time
>     Split out a xfs_setattr_time helper to share code between truncate and
>     regular setattr similar to xfs_setattr_mode.  I might also have another
>     caller growing for this in the near future.
>     Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>     Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
>     Signed-off-by: Ben Myers <bpm@xxxxxxx>
> Notes:
>     X-Patchwork-ID: 6941
>     Message-Id: <20131118131052.GB21649@xxxxxxxxxxxxx>

There are no notes in the oss repository that I can find. AFAIK,
notes stay in the local repo and don't get pushed. Basically, if you
want notes to be pushed/pulled, everyone has to use a non-standard
repository config to tell git to push/pull refs/notes.

Really, if it's necessary information, it should be in the commit
message. I've never used message IDs or patchworks IDs in my life,
so you can guess how necessary I consider that information to be....

> > As it is, patchworks is not something I use or want to use. I
> > capture and track patches with procmail and mutt - I really don't
> > want to have to use patchworks just to find some arbitrary ID number
> > that some 3rd party tool generates and add it to notes attached to a
> > commit.
> I'm a mutt user as well.  I'm not necessarily the biggest fan of patchwork
> either, but it does turn out to be helpful sometimes.  I don't know what your
> workflow is like.  Is there any chance you can get the message id in there?
> messageid=$(formail -X Message-Id: < $patch | awk '{print $2}')
> git notes append -m "Message-Id: $messageid"

Doesn't work for my workflow, because I don't keep individual
patches around - I pushed everything to mbox format files and then
bulk git-am the file. And that still doesn't solve the patchwork id
problem, or the fact non standard repo configs are needed to manage


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>