xfs
[Top] [All Lists]

Re: [PATCH] xfs: require 64-bit sector_t

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: require 64-bit sector_t
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 16 Dec 2013 16:15:59 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131114164603.GA13628@xxxxxxxxxxxxx>
References: <20131114164603.GA13628@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Christoph,

On Thu, Nov 14, 2013 at 08:46:03AM -0800, Christoph Hellwig wrote:
> Trying to support tiny disks only and saving a bit memory might have
> made sense on an SGI O2 15 years ago, but is pretty pointless today.
> 
> Remove the rarely tested codepath that uses various smaller in-memory
> types to reduce our test matrix and make the codebase a little bit
> smaller and less complicated.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

This looks ok to me.  I'm not seeing much downside to removing the smaller
in-memory types.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>