xfs
[Top] [All Lists]

Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid()
From: Zhi Yong Wu <zwu.kernel@xxxxxxxxx>
Date: Sat, 14 Dec 2013 19:43:59 +0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfstests <xfs@xxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>, linux-kernel mlist <linux-kernel@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=if6LPhc4cVJLuu3b2Q2pB++zZBlqVgbn6iWxOyHF7Y4=; b=ElA4bGLtj07n1gO9xBWb+tUUEOWyL/IOVXVs4b8JyES06BfHT9dLcyYrQGpkzqL/26 58cNCFI4bjbZlNr4Vg5uEyrnlgsv6h+FRVxWF2kzlMAKHiLNPY8b3QJIBaZzvBWQ6b+S vdg8WXk7rtY5S8F+/sqcRvVHJ4xfkiFtYJdaxW9jNy9u4Q9rgt3zzrtE7oKz6gzCxqUM cgX+j5HYkmRJISGs6vvMQa2qkB0sbBfpQRDdjBPlzIe7HHcJC9hiOqPzCwwFZM776cVq U+lcPbmg5TTQIKeuYqwAjANY2kIrwhNpSPh0K4MMeLhhfS8BvgsFIFjtf9j425BCE1q9 Qk9A==
In-reply-to: <52AC3EF1.6090106@xxxxxxxxxx>
References: <1386944873-16796-1-git-send-email-zwu.kernel@xxxxxxxxx> <1386944873-16796-2-git-send-email-zwu.kernel@xxxxxxxxx> <20131213163211.GD20803@xxxxxxxxxxxxx> <52AC3EF1.6090106@xxxxxxxxxx>
On Sat, Dec 14, 2013 at 7:20 PM, Jeff Liu <jeff.liu@xxxxxxxxxx> wrote:
> On 12/14 2013 00:32 AM, Christoph Hellwig wrote:
>>> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp)
>>> +{
>>> +    if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT)
>>> +            return xfs_get_projid(dp);
>>> +    else
>>> +            return XFS_PROJID_DEFAULT;
>>> +}
>>
>> You could skip the else here.
> Except that, I'd suggest we move this helper to proper header file with
> further refactoring in xfs_symlink(), and it could be a separate patch.
Good point, will apply it, thanks.

>
> Thanks,
> -Jeff



-- 
Regards,

Zhi Yong Wu

<Prev in Thread] Current Thread [Next in Thread>