| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, Zhi Yong Wu <zwu.kernel@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid() |
| From: | Jeff Liu <jeff.liu@xxxxxxxxxx> |
| Date: | Sat, 14 Dec 2013 19:20:17 +0800 |
| Cc: | xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20131213163211.GD20803@xxxxxxxxxxxxx> |
| References: | <1386944873-16796-1-git-send-email-zwu.kernel@xxxxxxxxx> <1386944873-16796-2-git-send-email-zwu.kernel@xxxxxxxxx> <20131213163211.GD20803@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/14 2013 00:32 AM, Christoph Hellwig wrote:
>> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp)
>> +{
>> + if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT)
>> + return xfs_get_projid(dp);
>> + else
>> + return XFS_PROJID_DEFAULT;
>> +}
>
> You could skip the else here.
Except that, I'd suggest we move this helper to proper header file with
further refactoring in xfs_symlink(), and it could be a separate patch.
Thanks,
-Jeff
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Guten Tag, Mr. SUN Zhijun |
|---|---|
| Next by Date: | Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid(), Zhi Yong Wu |
| Previous by Thread: | Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid(), Christoph Hellwig |
| Next by Thread: | Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid(), Zhi Yong Wu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |