xfs
[Top] [All Lists]

Re: [PATCH 5/5] xfs: allow linkat() on O_TMPFILE files

To: Zhi Yong Wu <zwu.kernel@xxxxxxxxx>
Subject: Re: [PATCH 5/5] xfs: allow linkat() on O_TMPFILE files
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 14 Dec 2013 19:19:44 +1100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>, linux-kernel mlist <linux-kernel@xxxxxxxxxxxxxxx>, xfstests <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CAEH94LimS8mUCFwmnVi876mG9GB7DWsqG9p1O=R41XJ3-u1NQg@xxxxxxxxxxxxxx>
References: <1386944873-16796-1-git-send-email-zwu.kernel@xxxxxxxxx> <1386944873-16796-6-git-send-email-zwu.kernel@xxxxxxxxx> <20131213164154.GH20803@xxxxxxxxxxxxx> <CAEH94LimS8mUCFwmnVi876mG9GB7DWsqG9p1O=R41XJ3-u1NQg@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Dec 14, 2013 at 01:36:47AM +0800, Zhi Yong Wu wrote:
> On Sat, Dec 14, 2013 at 12:41 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> > On Fri, Dec 13, 2013 at 10:27:53PM +0800, Zhi Yong Wu wrote:
> >> From: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>
> >>
> >> Enable O_TMPFILE support in linkat().
> >> For more info, please refer to:
> >>   http://oss.sgi.com/archives/xfs/2013-08/msg00341.html
> >
> > Generall you should provide all reasonable information in the changelog
> > instead of linking to it.
> will apply this, thanks.
> >
> >> +     if (sip->i_d.di_nlink == 0)
> >> +             tres = &M_RES(mp)->tr_link_tmpfile;
> >> +     else
> >> +             tres = &M_RES(mp)->tr_link;
> >
> > As mentioned before I think Dave wanted you to always use the same
> > reservation, but I'll leave that discussion to him.
> If as you said, when some tons of regular files are created, it won't
> waste some disk space? e.g. some files want to reserve some space, but
> get NOSPACE due to other files reserving additional space?

This is a log space reservation, not a disk space reservation. End
either way, what is unused by the transaction is returned to the
free space pool at the end of the transaction. So for simplicity,
we should just use the one reservation for the link transaction -
take whichever is larger at calculation time.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>