xfs
[Top] [All Lists]

Re: [PATCH 3/5] xfs: add xfs_create_tmpfile() for O_TMPFILE support

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/5] xfs: add xfs_create_tmpfile() for O_TMPFILE support
From: Zhi Yong Wu <zwu.kernel@xxxxxxxxx>
Date: Sat, 14 Dec 2013 01:29:58 +0800
Cc: xfstests <xfs@xxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>, linux-kernel mlist <linux-kernel@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=PJokIvdmn0oaXKK0FP9zB2KyqPUynstKv58TD01A7es=; b=Z9Qthy0AZXfhRShLBQ9gsxF2yBZzWNM/kw8ZQMJiWN/TXTa77zdAILF7G1Sn5lZzau 7I5uQflZQViRYvc9hKuWPhIiibS2pLmJZYfsILY9fI2nQkqxYz10aqjnGVAnVojpsAAy Qm8YZ6SMlk+8o9bZAW/gEKVupJIzWX0ZUjEU7qgdQZZIVtgwVCTbud5GiRk9HdNBs2fp 9HgX3IV1M9NqWa4ttEnA4kdZxKs0mJ9qawzTIKXVnqxveKAXXqEwA1lDAtWsCjfl5V5d WXXd5UuVSsvWNav2TsAvX1rAY8fkC6tDbGw0bWg9OG1njHHneH8ftakZTF2jni3salJh tBZQ==
In-reply-to: <20131213163733.GF20803@xxxxxxxxxxxxx>
References: <1386944873-16796-1-git-send-email-zwu.kernel@xxxxxxxxx> <1386944873-16796-4-git-send-email-zwu.kernel@xxxxxxxxx> <20131213163733.GF20803@xxxxxxxxxxxxx>
Fixed them, thanks.

On Sat, Dec 14, 2013 at 12:37 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>> +     error = xfs_dir_ialloc(&tp, NULL, mode, 0, rdev,
>
> please pass the parent inode pointer here.
>
>> +                             XFS_PROJID_DEFAULT, resblks > 0,
>
> and pass the project id that you inherited from the parent here.
>



-- 
Regards,

Zhi Yong Wu

<Prev in Thread] Current Thread [Next in Thread>