| To: | Zhi Yong Wu <zwu.kernel@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 13 Dec 2013 08:32:11 -0800 |
| Cc: | xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1386944873-16796-2-git-send-email-zwu.kernel@xxxxxxxxx> |
| References: | <1386944873-16796-1-git-send-email-zwu.kernel@xxxxxxxxx> <1386944873-16796-2-git-send-email-zwu.kernel@xxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp)
> +{
> + if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT)
> + return xfs_get_projid(dp);
> + else
> + return XFS_PROJID_DEFAULT;
> +}
You could skip the else here.
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 5/3] xfs: return unlocked dquots from xfs_qm_dqqet, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 2/5] xfs: adjust the interface of xfs_qm_vop_dqalloc(), Christoph Hellwig |
| Previous by Thread: | [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid(), Zhi Yong Wu |
| Next by Thread: | Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid(), Jeff Liu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |