xfs
[Top] [All Lists]

Re: [PATCH 4/6] xfs: swalloc doesn't align allocations properly

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/6] xfs: swalloc doesn't align allocations properly
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 13 Dec 2013 04:01:23 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1386826478-13846-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1386826478-13846-1-git-send-email-david@xxxxxxxxxxxxx> <1386826478-13846-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Looks good.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Two very minor nitpicks below:

> +     int             stripe_align;
>  
>       ASSERT(ap->length);
>  
>       mp = ap->ip->i_mount;
> +
> +     /* stripe alignment for allocation is determined by mount parameters */
> +     stripe_align = 0;
> +     if (mp->m_swidth && (mp->m_flags & XFS_MOUNT_SWALLOC))
> +             stripe_align = mp->m_swidth;
> +     else if (mp->m_dalign)
> +             stripe_align = mp->m_dalign;

nipick: I'd either initialize the variable to zero at the point of the
declaration or do if .. else if .. else here.

>       }
> +
> +
>       nullfb = *ap->firstblock == NULLFSBLOCK;

Two newlines seem odd here.  I'd support one even if that's an unrelated
change :)

<Prev in Thread] Current Thread [Next in Thread>