[Top] [All Lists]

Re: [PATCH 00/12] run more generic tests on TEST_DIR

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 00/12] run more generic tests on TEST_DIR
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 13 Dec 2013 12:09:34 +1100
Cc: xfs@xxxxxxxxxxx, Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131212180312.GC19422@xxxxxxxxxxxxx>
References: <20131211073445.353655850@xxxxxxxxxxxxxxxxxxxxxx> <20131211225012.GL10988@dastard> <20131212180312.GC19422@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Dec 12, 2013 at 10:03:12AM -0800, Christoph Hellwig wrote:
> On Thu, Dec 12, 2013 at 09:50:12AM +1100, Dave Chinner wrote:
> > I'm not sure this is such a good idea. The test_dir is a fixed
> > filesystem designed to persiste between test harness runs to allow
> > testing on an aged filesystem.
> Yes, and that's exactly what we want for the tests converted.

Well, that assertion is exactly what I'm disagreeing with. It
doesn't help me at all.

> > run the tests on a differently configured scratch device. I use this
> > all the time to change the filesystem config I'm testing against. By
> > moving all these tests to the TEST_DEV, these tests are no longer
> > run on the device that is configured specifically the way I want it
> > configured for the given test run.
> > 
> > So, I think this is a step backwards in terms of being able to
> > quickly iterate and cover different filesystem configurations, and
> > as such I don't really like it as a solution. What other options do
> > we have?
> You can have different test devices, or simply not bother with aging
> it for every run.  You're missing the coverage of all the test dir
> using tests, which are a lot with the above version anyway.

IOWs, you're saying that you don't consider MKFS_OPTIONS as a first
class citizen. I've been using it for 7 or 8 years for exactly this
purpose - iterating testing of a change quickly across multiple
configurations without perturbing the long term aging of the test

IOWs, taking 12 tests away from the scratch device significantly
reduces the coverage of my testing during development. It will
force me to have to change a fairly important part of my workflow -
a part that I haven't needed to change for several years.

I'll now need more VM image storage for the extra test devices I
need, I'll need multiple config files to handle the different test
filesystems, I'll need to write new scripts to mkfs the test devices
as well as setting the MKFS_OPTIONS for the scratch devices and
switch config files, etc.

I'm not opposed to making the change, just pointing out that
reducing the usage of the scratch device has a fairly significant
impact on test coverage for anyone who uses MKFS_OPTIONS in their


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>