[Top] [All Lists]

Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.
From: Junho Ryu <jayr@xxxxxxxxxx>
Date: Thu, 12 Dec 2013 16:00:44 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Hugh Dickins <hughd@xxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Boris Ranto <branto@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=CQe06OChRMPHfcsPEs6D28NBxkHb/3Nl1RQPHfhl/aY=; b=IW1D0hpZhlD/iiFdlJ4wEkH65hkjk0f1dQSUAsvnJAn78Ui2s3NztI2R6hJdr99ek/ P/MMMBBlRTnI07qb6+GFYd+809ueCv0Nd9zv3Rx+dluSCvhQ2LvoEQx9/DR4vxgznVzP mybjV77aq5p26gtP07yJJKd0ZwTGmvDDWJfYKiT0PqscT/7w/fuEpcDuWfuO5w2TfWbo mCnX9A7ZXHwjAIhAt6/MJWI/LGg/C0c1aiGdctxLVYXjWZcK1MeHLJWrQdPrSOW4vbcs ACjOmDuCZ7jvH8QDheOqefy03zDPSrDvjm7pNtsijEIdvOmQlm+gx5PkUvyhYAkgYFkb D/eA==
In-reply-to: <20131212225657.GK10988@dastard>
References: <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx> <1386706321-15795-6-git-send-email-jayr@xxxxxxxxxx> <20131211074615.GE19248@xxxxxxxxxxxxx> <20131211224012.GJ10988@dastard> <20131212180130.GA19422@xxxxxxxxxxxxx> <20131212225657.GK10988@dastard>
> I don't know what the solution here is - everything I think of is
> either messy, ugly or unmaintainable. All I'm trying to do is find a
> way to handle tmpfs filesystems in a way that is maintainable and
> doesn't require every developer to be aware of the quirks of tmpfs
> when writing and reviewing new generic tests....

If it is acceptable that tmpfs running tests which does not make much
sense without actually re-mounting devices, all other developers need
to care is using _scratch_remount() and _test_remount().

Even if someone does not use the functions, tests will only fail on
tmpfs, and people like me who cares about it will be happy to fix it.

So far, generic/053 is the only test which does something else between
umount and mount.

<Prev in Thread] Current Thread [Next in Thread>