xfs
[Top] [All Lists]

Re: [PATCH v2 0/8] xfs: Introduce a common helper to calculate the numbe

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH v2 0/8] xfs: Introduce a common helper to calculate the number of blocks per cluster
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 13 Dec 2013 09:19:52 +1100
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52A967C6.1050303@xxxxxxxxxx>
References: <52A967C6.1050303@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Dec 12, 2013 at 03:37:42PM +0800, Jeff Liu wrote:
> Hi Folks,
> 
> Here is the v2 patch series to introduce a common helper which could be used
> to calculate the number of file system blocks in an inode cluster.
> 
> v2->v1:
> * Rename xfs_ialloc_blks_per_cluster() to xfs_icluster_size_fsb() as per 
> dave's
>   suggestion.
> * Remove three macros 
> XFS_IALLOC_INODES/XFS_INODE_CLUSTER_SIZE/XFS_IALLOC_BLOCKS
>   separately as preparation steps.
> * s/ninodes/inodes_per_cluster/g, as the later is more meaningful.
> * Remove wrong commit notes I previously written for using 
> xfs_ialloc_blks_per_cluster
>   in xfs_imap(). 

All looks good, Jeff. Nice work, and thanks for adding all the extra
cleanups to it :)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>