xfs
[Top] [All Lists]

Re: [PATCH v2 3/8] xfs: get rid of XFS_IALLOC_BLOCKS macros

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH v2 3/8] xfs: get rid of XFS_IALLOC_BLOCKS macros
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 13 Dec 2013 09:09:53 +1100
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52A967E9.7070508@xxxxxxxxxx>
References: <52A967E9.7070508@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Dec 12, 2013 at 03:38:17PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Get rid of XFS_IALLOC_BLOCKS() marcos, use mp->m_ialloc_blks directly.
> 
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
....
> @@ -1228,9 +1228,9 @@ xfs_difree(
>                       goto error0;
>               }
>  
> -             xfs_bmap_add_free(XFS_AGB_TO_FSB(mp,
> -                             agno, XFS_INO_TO_AGBNO(mp,rec.ir_startino)),
> -                             XFS_IALLOC_BLOCKS(mp), flist, mp);
> +             xfs_bmap_add_free(XFS_AGB_TO_FSB(mp, agno,
> +                               XFS_INO_TO_AGBNO(mp, rec.ir_startino)),
> +                               mp->m_ialloc_blks, flist, mp);
>       } else {
>               *delete = 0;
>  

git-am fails to apply this hunk, but I'm not sure why. I updated it
manually, the resulting patch looks identical.

Other than that, it looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>