xfs
[Top] [All Lists]

Re: [PATCH 05/18] fs: make posix_acl_chmod more useful

To: Andreas Gruenbacher <andreas.gruenbacher@xxxxxxxxxx>
Subject: Re: [PATCH 05/18] fs: make posix_acl_chmod more useful
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 12 Dec 2013 13:05:02 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, reiserfs-devel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, Jan Kara <jack@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <389888733.69110.1386875240679.JavaMail.zimbra@xxxxxxxxxx>
References: <20131211104243.148113893@xxxxxxxxxxxxxxxxxxxxxx> <20131211104527.223923019@xxxxxxxxxxxxxxxxxxxxxx> <389888733.69110.1386875240679.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Dec 12, 2013 at 08:07:20PM +0100, Andreas Gruenbacher wrote:
> Christoph,
> 
> > +int
> > +posix_acl_chmod(struct inode *inode)
> > +{
> > +   struct posix_acl *acl;
> > +   int ret = 0;
> > +
> > +   if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl)
> > +           return -EOPNOTSUPP;
> 
> Symlinks never have get_acl callbacks, so I would remove the S_ISLNK() check 
> here.

Yeah, will simplify it.  Same for the other places where we have both
checks.

<Prev in Thread] Current Thread [Next in Thread>