xfs
[Top] [All Lists]

Re: [PATCH 02/18] fs: add get_acl helper

To: Andreas Gruenbacher <andreas.gruenbacher@xxxxxxxxxx>
Subject: Re: [PATCH 02/18] fs: add get_acl helper
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 12 Dec 2013 13:04:39 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, reiserfs-devel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, Jan Kara <jack@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1724169901.69108.1386875169382.JavaMail.zimbra@xxxxxxxxxx>
References: <20131211104243.148113893@xxxxxxxxxxxxxxxxxxxxxx> <20131211104526.648135334@xxxxxxxxxxxxxxxxxxxxxx> <1724169901.69108.1386875169382.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Dec 12, 2013 at 08:06:09PM +0100, Andreas Gruenbacher wrote:
> > +   /*
> > +    * A filesystem can force a ACL callback by just never filling the
> > +    * ACL cache. But normally you'd fill the cache either at inode
> > +    * instantiation time, or on the first ->get_acl call.
> > +    *
> > +    * If the filesystem doesn't have a get_acl() function at all, we'll
> > +    * just create the negative cache entry.
> > +    */
> > +   if (!inode->i_op->get_acl) {
> > +           set_cached_acl(inode, type, NULL);
> > +           return ERR_PTR(-EAGAIN);
> 
> The function should return NULL here.

Indeed.  EAGAIN is the convention check_acl() in fs/namei.c uses,
but it will return that automatically if we just return NULL here.

<Prev in Thread] Current Thread [Next in Thread>