| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/5] repair: limit auto-striding concurrency apprpriately |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 13 Dec 2013 08:00:40 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20131212182908.GD10092@xxxxxxxxxxxxx> |
| References: | <1386832945-19763-1-git-send-email-david@xxxxxxxxxxxxx> <1386832945-19763-6-git-send-email-david@xxxxxxxxxxxxx> <20131212182908.GD10092@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 12, 2013 at 10:29:08AM -0800, Christoph Hellwig wrote: > Looks reasonable, but it might be worth to add a blurb on how you > arrived at the magic 8 threads per cpu. OK - that was simply that processing with 8 threads is more than enough to saturate a single CPU on fast devices so we don't need any more parallelism in this case. And when you have large slow devices, 8 threads is more than enough to saturate the IO subsystem.... I'll add a comment mentioning that. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/5] libxfs: buffer cache hashing is suboptimal, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 02/18] fs: add get_acl helper, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 5/5] repair: limit auto-striding concurrency apprpriately, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 5/5] repair: limit auto-striding concurrency apprpriately, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |