xfs
[Top] [All Lists]

Re: [PATCH] xfs_metadump: Make -F (force) optional

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_metadump: Make -F (force) optional
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 12 Dec 2013 14:01:16 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131212183115.GA16378@xxxxxxxxxxxxx>
References: <52A9F6CF.1070300@xxxxxxxxxx> <20131212183115.GA16378@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
On 12/12/13, 12:31 PM, Christoph Hellwig wrote:
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
>> xfs_metadump will pass "-F" to xfs_db to carry on even in the face
>> of bad superblock magic. [1]  Depending on what we gave as an input
>> file, we may very well fail quite badly:
>>
>>> xfs_metadump: /root/anaconda.cfg is not a valid XFS filesystem (unexpected 
>>> SB magic number 0x230a2320)
>>> Floating point exception
>>
>> I don't think it's possible to harden every path through libxfs for
>> non-xfs filesystems as input.  (Even if it's possible, I don't think it's
>> worth the effort).
> 
> Can you add a test to verify that xfs_metadump now correctly rejects
> files that don't have a valid superblock?

ok, can do.

Thanks Christoph,

-Eric

> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>