xfs
[Top] [All Lists]

Re: [PATCH 04/18] fs: add generic xattr_acl handlers

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/18] fs: add generic xattr_acl handlers
From: Andreas Gruenbacher <andreas.gruenbacher@xxxxxxxxxx>
Date: Thu, 12 Dec 2013 20:07:54 +0100 (CET)
Cc: viro@xxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, reiserfs-devel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, Jan Kara <jack@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131211104527.044064384@xxxxxxxxxxxxxxxxxxxxxx>
References: <20131211104243.148113893@xxxxxxxxxxxxxxxxxxxxxx> <20131211104527.044064384@xxxxxxxxxxxxxxxxxxxxxx>
Thread-index: LpXJCtrFY8l7N0wRtk1Ipy0lU/R8dg==
Thread-topic: add generic xattr_acl handlers
Christoph,

> +static int
> +posix_acl_xattr_set(struct dentry *dentry, const char *name,
> +             const void *value, size_t size, int flags, int type)
> +{
> +     struct inode *inode = dentry->d_inode;
> +     struct posix_acl *acl = NULL;
> +     int ret;
> +
> +     if (!IS_POSIXACL(inode))
> +             return -EOPNOTSUPP;
> +     if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl)
> +             return -EOPNOTSUPP;

Sama here, I would remove the S_ISLNK() check.

Andreas

<Prev in Thread] Current Thread [Next in Thread>