| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 05/18] fs: make posix_acl_chmod more useful |
| From: | Andreas Gruenbacher <andreas.gruenbacher@xxxxxxxxxx> |
| Date: | Thu, 12 Dec 2013 20:07:20 +0100 (CET) |
| Cc: | viro@xxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, reiserfs-devel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, Jan Kara <jack@xxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20131211104527.223923019@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20131211104243.148113893@xxxxxxxxxxxxxxxxxxxxxx> <20131211104527.223923019@xxxxxxxxxxxxxxxxxxxxxx> |
| Thread-index: | 7P+KktW5IEJf5zug8KVMXrtQ4EdvpQ== |
| Thread-topic: | make posix_acl_chmod more useful |
Christoph,
> +int
> +posix_acl_chmod(struct inode *inode)
> +{
> + struct posix_acl *acl;
> + int ret = 0;
> +
> + if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl)
> + return -EOPNOTSUPP;
Symlinks never have get_acl callbacks, so I would remove the S_ISLNK() check
here.
Andreas
|
| Previous by Date: | Re: [PATCH 02/18] fs: add get_acl helper, Andreas Gruenbacher |
|---|---|
| Next by Date: | Re: [PATCH 04/18] fs: add generic xattr_acl handlers, Andreas Gruenbacher |
| Previous by Thread: | [PATCH 05/18] fs: make posix_acl_chmod more useful, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 05/18] fs: make posix_acl_chmod more useful, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |