Re: [PATCH 02/18] fs: add get_acl helper

[Andreas Gruenbacher <andreas.gruenbacher@xxxxxxxxxx>]

Christoph,

> +struct posix_acl *get_acl(struct inode *inode, int type)
> +{
> +     struct posix_acl *acl;
> +
> +     acl = get_cached_acl(inode, type);
> +     if (acl != ACL_NOT_CACHED)
> +             return acl;
> +
> +     if (!IS_POSIXACL(inode))
> +             return NULL;
> +
> +     /*
> +      * A filesystem can force a ACL callback by just never filling the
> +      * ACL cache. But normally you'd fill the cache either at inode
> +      * instantiation time, or on the first ->get_acl call.
> +      *
> +      * If the filesystem doesn't have a get_acl() function at all, we'll
> +      * just create the negative cache entry.
> +      */
> +     if (!inode->i_op->get_acl) {
> +             set_cached_acl(inode, type, NULL);
> +             return ERR_PTR(-EAGAIN);

The function should return NULL here.

Andreas