xfs
[Top] [All Lists]

Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error.

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/6] xfs: don't try to mark uncached buffers stale on error.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 12 Dec 2013 08:36:29 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1386826478-13846-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1386826478-13846-1-git-send-email-david@xxxxxxxxxxxxx> <1386826478-13846-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
I really don't like how this makes even more of a mess out of the
already convoluted xfs_bioerror/xfs_bioerror_else maze.  Can we
maybe first merge them and document the difference before adding
even more special case branches?

Also most uses of uncached buffers use xfsbdstrat, where we can do
error handling straight in the caller instead of playing with all
the flags manipulation mess.  In all these cases no one but the
caller can find these buffers anyway, so doing all this on an
I/O error is pointless.

The only buffer where any of this matters is the superblock one,
and given that we re-read it on mount anyway I wonder if we should
just make it a regular buffer again and let all this mess just
disappear.

<Prev in Thread] Current Thread [Next in Thread>