[Top] [All Lists]

Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.

To: Theodore Ts'o <tytso@xxxxxxx>
Subject: Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 12 Dec 2013 11:53:43 +1100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Junho Ryu <jayr@xxxxxxxxxx>, hughd@xxxxxxxxxx, branto@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131212001655.GA31768@xxxxxxxxx>
References: <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx> <1386706321-15795-6-git-send-email-jayr@xxxxxxxxxx> <20131211074615.GE19248@xxxxxxxxxxxxx> <20131211224012.GJ10988@dastard> <20131212001655.GA31768@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Dec 11, 2013 at 07:16:55PM -0500, Theodore Ts'o wrote:
> On Thu, Dec 12, 2013 at 09:40:12AM +1100, Dave Chinner wrote:
> > > 
> > > All these tests don't make sense if you never unmount the filesystem.
> > > Istead they should exit with _notrun for tmpfs.
> > 
> > IOWs, adding tmpfs changes the definition of a "generic" test.
> > 
> > i.e. instead of:
> > 
> > _supported_fs generic
> > 
> > these tests are now:
> > 
> > _supported_fs xfs ext2 ext3 ext4 ext4dev btrfs gfs2 nfs udf reiserfs
> > 
> > and by that definition should be in the tests/shared directory....
> At a higher level, I wonder how useful having the distinction between
> "generic" and "shared" really is.  Suppose in the future we add some
> tests for networked file systems or cluster file systems --- do we end
> up migrating even more tests from "generic" to "shared" when we find
> tests that don't work for some new file system?

That's not the problem I'm pointing out. The physical location ofthe
test at this point is irrelevant.

The fundamental problem is that "generic" is a wildcard that we use
to match all filesystems, and so adding a new filesystem changes
the definition and suddenly tests that were generic now no longer
run on all filesystems.

> And to the extent that we have things like 
> _require_<feature>
> which skips certain tests, it's not even true that all generic tests
> are run for all file systems.

_supported_fs is just a _requires_<foo> statement on steriods.
"generic" simply documents tests that are expected to run on every
single filesystem we can throw at it.

The thing is, tmpfs is a very special snowflake - it's a volatile
filesystem. xfstests was never designed to handle filesystems that
destroy their contents on unmount, and so adding a filesystem that
*doesn't support unmount/remount* breaks fundamental assumptions the
test harness makes about how filesystems behave.

Hence adding tmpfs support means that a generic test can no longer
unmount and mount filesystems. That's a major change in test
architecture right there, and I'm not sure we start turning stuff
upside down to support wacky quirks like volatile filesystems we
can't unmount...

That's the bigger issue here - tmpfs fundamentally violates the
assumption that xfstests is based on - that filesystems are
non-volatile and persist across unmount and hence can be rigorously
validated after an unmount...

The result of this is it changes cwthe definition of what a
"generic" filesystem is, and then everything flows downhill from

> Perhaps it would make more sense to move all of the generic test to
> shared, and eliminating the distinction?  That way it also becomes
> easier becase we don't need to remember whether a test is generic/NNN
> vs shared/NNN.  :-)

Again, that does not solve the problem of tmpfs changing the
definition of a "generic" filesystem....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>