[Top] [All Lists]

Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Wed, 11 Dec 2013 19:16:55 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Junho Ryu <jayr@xxxxxxxxxx>, hughd@xxxxxxxxxx, branto@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=thunk.org; s=mail; t=1386807415; bh=AkEGya7YAdrQTI3aT2IzsDbWvJRZx35Hbp989v946q4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sWssNSN+cAD3iyJ3ohYQTTqCRNqwhvOEImg+J+Q0vnYBSz5q3zi1aVf/wwC53R5FQ 4dN2v/WX+nhBU8G6Kzq666bTZM3019eZ0ShFYtB8Oz35bzcz4Lf2FrKyh2pB940Z4n StNewfxC+OtL/WKi27+qRlWqeUbeyMoySQMBh+LQ=
In-reply-to: <20131211224012.GJ10988@dastard>
References: <1386706321-15795-1-git-send-email-jayr@xxxxxxxxxx> <1386706321-15795-6-git-send-email-jayr@xxxxxxxxxx> <20131211074615.GE19248@xxxxxxxxxxxxx> <20131211224012.GJ10988@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Dec 12, 2013 at 09:40:12AM +1100, Dave Chinner wrote:
> > 
> > All these tests don't make sense if you never unmount the filesystem.
> > Istead they should exit with _notrun for tmpfs.
> IOWs, adding tmpfs changes the definition of a "generic" test.
> i.e. instead of:
> _supported_fs generic
> these tests are now:
> _supported_fs xfs ext2 ext3 ext4 ext4dev btrfs gfs2 nfs udf reiserfs
> and by that definition should be in the tests/shared directory....

At a higher level, I wonder how useful having the distinction between
"generic" and "shared" really is.  Suppose in the future we add some
tests for networked file systems or cluster file systems --- do we end
up migrating even more tests from "generic" to "shared" when we find
tests that don't work for some new file system?

And to the extent that we have things like 


which skips certain tests, it's not even true that all generic tests
are run for all file systems.  So what should be the proper
distinction between generic and shared tests?  Whether we use
"_require_*" vs "_supported_fs"?  And if so, it seems rather arbitrary
that we decide whether not running a test based on the file system
type being <foo> is fundamentally different from deciding not to run a
test becuase we are missing the feature <bar>.

Perhaps it would make more sense to move all of the generic test to
shared, and eliminating the distinction?  That way it also becomes
easier becase we don't need to remember whether a test is generic/NNN
vs shared/NNN.  :-)

Just a thought,

                                        - Ted

<Prev in Thread] Current Thread [Next in Thread>